Skip to content

Mis-used string pointers in opendkim.c and vbr.c #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Mis-used string pointers in opendkim.c and vbr.c #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libvbr/vbr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,8 +1065,7 @@ vbr_query(VBR *vbr, u_char **res, u_char **cert)
vbr->vbr_dns_service == NULL &&
vbr->vbr_dns_init(&vbr->vbr_dns_service) != 0)
{
snprintf(vbr->vbr_error, sizeof vbr->vbr_error,
"unable to start resolver for '%s'",
vbr_error(vbr, "unable to start resolver for '%s'",
query);
return VBR_STAT_DNSERROR;
}
Expand All @@ -1077,8 +1076,7 @@ vbr_query(VBR *vbr, u_char **res, u_char **cert)

if (status != VBR_STAT_OK)
{
snprintf(vbr->vbr_error, sizeof vbr->vbr_error,
"unable to start query for '%s'",
vbr_error(vbr, "unable to start query for '%s'",
query);
return VBR_STAT_DNSERROR;
}
Expand Down
2 changes: 1 addition & 1 deletion opendkim/opendkim.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5020,7 +5020,7 @@ dkimf_add_signrequest(struct msgctx *dfc, DKIMF_DB keytable, char *keyname,
}

if (domain[0] == '%' && domain[1] == '\0' &&
dfc->mctx_domain == NULL)
dfc->mctx_domain[0] == '\0')
{
if (dolog)
{
Expand Down