Skip to content

fix: properly handle go.mod files with no dependencies #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix: properly handle go.mod files with no dependencies #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/providers/golang_gomodules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,17 +258,22 @@ function getSBOM(manifest, opts = {}, includeTransitive) {
}
let manifestDir = path.dirname(manifest)
try {
var goGraphOutput = invokeCommand(goBin, ['mod', 'graph'], {cwd: manifestDir}).toString()
var goGraphOutput = invokeCommand(goBin, ['mod', 'graph'], {cwd: manifestDir}).toString().trim()
} catch(error) {
throw new Error('failed to invoke go binary for module graph', {cause: error})
}

try {
var goModEditOutput = JSON.parse(invokeCommand(goBin, ["mod", "edit", "-json"], {cwd: manifestDir}).toString().trim())
} catch(error) {
throw new Error('failed to determine root module name', {cause: error})
}

let ignoredDeps = getIgnoredDeps(manifest);
let allIgnoredDeps = ignoredDeps.map((dep) => dep.toString())
let sbom = new Sbom();
let rows = goGraphOutput.split(getLineSeparatorGolang()).filter(line => {
return !line.includes(' go@');
});
let root = getParentVertexFromEdge(rows[0])
let rows = goGraphOutput.split(getLineSeparatorGolang()).filter(line => !line.includes(' go@'));
let root = getParentVertexFromEdge(goModEditOutput['Module']['Path'])
let matchManifestVersions = getCustom("MATCH_MANIFEST_VERSIONS", "false", opts);
if(matchManifestVersions === "true") {
performManifestVersionsCheck(root, rows, manifest)
Expand All @@ -278,7 +283,7 @@ function getSBOM(manifest, opts = {}, includeTransitive) {
sbom.addRoot(mainModule)
const exhortGoMvsLogicEnabled = getCustom("EXHORT_GO_MVS_LOGIC_ENABLED", "false", opts)
if(includeTransitive && exhortGoMvsLogicEnabled === "true") {
rows = getFinalPackagesVersionsForModule(rows,manifest,goBin)
rows = getFinalPackagesVersionsForModule(rows, manifest, goBin)
}
if (includeTransitive) {
let currentParent = ""
Expand Down
3 changes: 2 additions & 1 deletion test/providers/golang_gomodules.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ suite('testing the golang-go-modules data provider', () => {
"go_mod_no_ignore",
"go_mod_with_ignore",
"go_mod_test_ignore",
"go_mod_with_all_ignore"
"go_mod_with_all_ignore",
"go_mod_empty"
].forEach(testCase => {
let scenario = testCase.replace('go_mod_', '').replaceAll('_', ' ')
test(`verify go.mod sbom provided for stack analysis with scenario ${scenario}`, () => {
Expand Down
27 changes: 27 additions & 0 deletions test/providers/tst_manifests/golang/go_mod_empty/expected_sbom_component_analysis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"bomFormat": "CycloneDX",
"specVersion": "1.4",
"version": 1,
"metadata": {
"timestamp": "2023-08-07T00:00:00.000Z",
"component": {
"group": "github.com/sample",
"name": "empty-module",
"version": "v0.0.0",
"purl": "pkg:golang/github.com/sample/[email protected]",
"type": "application",
"bom-ref": "pkg:golang/github.com/sample/[email protected]"
}
},
"components": [
{
"group": "github.com/sample",
"name": "empty-module",
"version": "v0.0.0",
"purl": "pkg:golang/github.com/sample/[email protected]",
"type": "application",
"bom-ref": "pkg:golang/github.com/sample/[email protected]"
}
],
"dependencies": []
}
52 changes: 52 additions & 0 deletions test/providers/tst_manifests/golang/go_mod_empty/expected_sbom_stack_analysis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"bomFormat": "CycloneDX",
"specVersion": "1.4",
"version": 1,
"metadata": {
"timestamp": "2023-08-07T00:00:00.000Z",
"component": {
"group": "github.com/sample",
"name": "empty-module",
"version": "v0.0.0",
"purl": "pkg:golang/github.com/sample/[email protected]",
"type": "application",
"bom-ref": "pkg:golang/github.com/sample/[email protected]"
}
},
"components": [
{
"group": "github.com/sample",
"name": "empty-module",
"version": "v0.0.0",
"purl": "pkg:golang/github.com/sample/[email protected]",
"type": "application",
"bom-ref": "pkg:golang/github.com/sample/[email protected]"
},
{
"name": "go",
"version": "1.24",
"purl": "pkg:golang/[email protected]",
"type": "library",
"bom-ref": "pkg:golang/[email protected]"
},
{
"name": "toolchain",
"version": "go1.24",
"purl": "pkg:golang/[email protected]",
"type": "library",
"bom-ref": "pkg:golang/[email protected]"
}
],
"dependencies": [
{
"ref": "pkg:golang/[email protected]",
"dependsOn": [
"pkg:golang/[email protected]"
]
},
{
"ref": "pkg:golang/[email protected]",
"dependsOn": []
}
]
}
3 changes: 3 additions & 0 deletions test/providers/tst_manifests/golang/go_mod_empty/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/sample/empty-module

go 1.24
Loading