-
Notifications
You must be signed in to change notification settings - Fork 18
chore(deps): consolidate requirements #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruivieira PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @EmilienM!
I've rebased it, can someone re-review it? thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @EmilienM!
it's failing in CI:
Probably a mistake in my rebase, I'll fix it tomorrow. Don't merge this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EmilienM the container build is failing, and IIUC, the problem is in huggingface/requirements.in
. It's referencing ../common/requirements.txt
but the Dockerfile copies both common/requirements.txt
and huggingface/requirements.txt
to the same directory as just requirements.txt
. So we have two files named requirements.txt
in the same folder and the relative path ../common/requirements.txt
doesn't exist anymore
Introduces `requirements.in` files for the `huggingface` and `llm_judge` detectors to streamline dependency installation. Fixes trustyai-explainability#19 Signed-off-by: Emilien Macchi <[email protected]>
PR image build completed successfully! 📦 Huggingface PR image: |
Introduces
requirements.in
files for thehuggingface
andllm_judge
detectors to streamline dependency installation.
Fixes #19
Signed-off-by: Emilien Macchi [email protected]
Summary by Sourcery
Consolidate dependency management in detector Docker builds by introducing requirements.in files for the Hugging Face and LLM Judge detectors and updating their Dockerfiles accordingly.
Bug Fixes:
requirements.in
#19 by ensuring a consistent dependency setup in Docker buildsEnhancements:
Build: