Skip to content

Conversation

EmilienM
Copy link

@EmilienM EmilienM commented Jun 30, 2025

Introduces requirements.in files for the huggingface and llm_judge
detectors to streamline dependency installation.

Fixes #19
Signed-off-by: Emilien Macchi [email protected]

Summary by Sourcery

Consolidate dependency management in detector Docker builds by introducing requirements.in files for the Hugging Face and LLM Judge detectors and updating their Dockerfiles accordingly.

Bug Fixes:

Enhancements:

  • Streamline Python dependency installation for Hugging Face and LLM Judge detectors using requirements.in files

Build:

  • Add requirements.in files for the detectors and update Dockerfiles to install dependencies from them

Copy link

sourcery-ai bot commented Jun 30, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@EmilienM EmilienM changed the title chore(deps): Consolidate requirements for detector Docker builds chore(deps): consolidate requirements for detector Docker builds Jun 30, 2025
@EmilienM EmilienM changed the title chore(deps): consolidate requirements for detector Docker builds chore(deps): consolidate requirements Jun 30, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EmilienM - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EmilienM
Copy link
Author

@ruivieira PTAL

@ruivieira ruivieira added the enhancement New feature or request label Jun 30, 2025
Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EmilienM!

@EmilienM
Copy link
Author

I've rebased it, can someone re-review it? thank you

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EmilienM!

@ruivieira ruivieira moved this to In Review in TrustyAI planning Sep 30, 2025
@EmilienM
Copy link
Author

it's failing in CI:

0.449 ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/common/requirements.txt'

Probably a mistake in my rebase, I'll fix it tomorrow. Don't merge this yet.

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilienM the container build is failing, and IIUC, the problem is in huggingface/requirements.in. It's referencing ../common/requirements.txt but the Dockerfile copies both common/requirements.txt and huggingface/requirements.txt to the same directory as just requirements.txt. So we have two files named requirements.txt in the same folder and the relative path ../common/requirements.txt doesn't exist anymore

Introduces `requirements.in` files for the `huggingface` and `llm_judge`
detectors to streamline dependency installation.

Fixes trustyai-explainability#19
Signed-off-by: Emilien Macchi <[email protected]>
Copy link

github-actions bot commented Oct 1, 2025

PR image build completed successfully!

📦 Huggingface PR image: quay.io/trustyai/guardrails-detector-huggingface-runtime-ci:$PR_HEAD_SHA
📦 Built-in PR image: quay.io/trustyai/guardrails-detector-built-in-ci:$PR_HEAD_SHA
📦 LLM Judge PR image: quay.io/trustyai/guardrails-detector-llm-judge-ci:$PR_HEAD_SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

consolidate requirements files using a requirements.in

2 participants