Skip to content

Delete comented out code #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domoritz wants to merge 1 commit into from
Closed

Delete comented out code #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 2 additions & 41 deletions js/src/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ export class Table<T extends { [key: string]: DataType } = any> {
constructor(...args: any[]) {

if (args.length === 0) {
this.data = []
this.data = [];
this.schema = new Schema([]);
this._offsets = new Uint32Array([0]);
return this;
}

let data: RecordBatch<T>[] = [];
const data: RecordBatch<T>[] = [];
let schema: Schema<T> | undefined = undefined;
let offsets: Uint32Array | undefined = undefined;

Expand Down Expand Up @@ -135,45 +135,6 @@ export class Table<T extends { [key: string]: DataType } = any> {
this.data = data;
this.schema = schema;
this._offsets = offsets ?? computeChunkOffsets(this.data.map((b) => b.data));

// if (args.length === 1 && !(args[0] instanceof Schema)) {
// const [obj] = args as [{ [P in keyof T]: Vector<T[P]> }];
// const batches = Object.keys(obj).reduce((batches, name: keyof T) => {
// obj[name].data.forEach((data, batchIndex) => {
// if (!batches[batchIndex]) {
// batches[batchIndex] = {} as { [P in keyof T]: Data<T[P]> };
// }
// batches[batchIndex][name] = new Vector(data).data[0];
// });
// return batches;
// }, new Array<{ [P in keyof T]: Data<T[P]> }>());

// args = [batches[0].schema, batches.map((data) => new RecordBatch<T>(data))];
// }

// let [schema, data, offsets] = args;

// if (!(schema instanceof Schema)) {
// throw new TypeError('Table constructor expects a [Schema, RecordBatch[]] pair.');
// }

// this.schema = schema;

// [, data = [new _InternalEmptyPlaceholderRecordBatch(schema)]] = args;

// const batches: RecordBatch<T>[] = Array.isArray(data) ? data : [data];

// batches.forEach((batch: RecordBatch<T>) => {
// if (!(batch instanceof RecordBatch)) {
// throw new TypeError('Table constructor expects a [Schema, RecordBatch[]] pair.');
// }
// if (!compareSchemas(this.schema, batch.schema)) {
// throw new TypeError('Table and all RecordBatch schemas must be equivalent.');
// }
// });

// this.data = batches;
// this._offsets = offsets ?? computeChunkOffsets(this.data.map((b) => b.data));
}

declare protected _offsets: Uint32Array;
Expand Down