Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds propagate_tags to ecs service, task role output #40

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

alexmaras
Copy link
Contributor

I've got two changes bundled up here:

  1. add propagate_tags to all aws_ecs_service resources, and a variable task_propagate_tags to control it. This allows for accurate cost tracking in AWS, as previously, the ECS tasks weren't tagged at all when run. This accounts for a large portion of the cost.
  2. add the IAM task role name and ARN as outputs. This allows for permissions to be added to tasks, such as accessing secrets manager, without directly editing the module.

image

image
becomes
image

Copy link
Contributor

@roberto-retool roberto-retool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change!

@roberto-retool roberto-retool merged commit fd5ac51 into tryretool:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants