update ecs template with unprivileged mode and correct user/group #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimoondra
commented
Jun 26, 2024
avimoondra
commented
Jun 26, 2024
Comment on lines
+468
to
+469
| name = "CONTAINER_UNPRIVILEGED_MODE" | ||
| value = "true" |
There was a problem hiding this comment.
ECS Fargate cannot use privileged containers atm, turn off sandboxing.
roberto-retool
approved these changes
Jun 26, 2024
avimoondra
commented
Jun 26, 2024
| @@ -460,9 +461,14 @@ resource "aws_ecs_task_definition" "retool_code_executor" { | |||
| } | |||
| ] | |||
|
|
|||
| environment = concat( | |||
| environment = compact(concat( | |||
There was a problem hiding this comment.
avimoondra
force-pushed
the
avimoondra/udpate-ecs-1001
branch
from
12ef19f to
3fdb2f2
Compare
roberto-retool
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update ecs template with unprivileged mode and correct user/group