Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate separated ecs ec2 module #50

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

avimoondra
Copy link
Contributor

No description provided.

Copy link
Contributor

@roberto-retool roberto-retool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we leave just the deprecation notice?
this could break a module if it's being imported via github path e.g.

module "retool" {
  source = "github.com/tryretool/terraform-retool-modules/aws_ecs_ec2"
}

@avimoondra
Copy link
Contributor Author

should we leave just the deprecation notice? this could break a module if it's being imported via github path e.g.

module "retool" {
  source = "github.com/tryretool/terraform-retool-modules/aws_ecs_ec2"
}

Ah didn't realize that was a thing. Makes sense.

@avimoondra avimoondra force-pushed the avimoondra/deprecate-ecs-ec2-separated branch from 47acf56 to 04e88d6 Compare June 26, 2024 14:02
@avimoondra avimoondra merged commit 58918e5 into main Jun 26, 2024
@avimoondra avimoondra deleted the avimoondra/deprecate-ecs-ec2-separated branch June 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants