Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration variables for Retool & Temporal RDS clusters/instances #52

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add configuration variables for Retool & Temporal RDS clusters/instances #52

merged 1 commit into from
Jul 18, 2024

Conversation

briferz
Copy link
Contributor

@briferz briferz commented Jul 16, 2024

This pull request primarily focuses on enhancing the configurability of the AWS ECS module for the Temporal Aurora and RDS instance. The changes introduce new variables to allow customization of engine version, serverless capacity, and instances for Temporal Aurora, as well as enabling storage encryption for the RDS instance.

Key changes include:

New Variables Introduced:

  • modules/aws_ecs/temporal/variables.tf and modules/aws_ecs/variables.tf: Introduced new variables temporal_aurora_engine_version, temporal_aurora_serverless_min_capacity, temporal_aurora_serverless_max_capacity, temporal_aurora_instances, and rds_instance_storage_encrypted to allow customization of Temporal Aurora and RDS instance settings. [1] [2] [3]

Use of New Variables:

  • modules/aws_ecs/main.tf: The new variables rds_instance_storage_encrypted and temporal_aurora_engine_version, temporal_aurora_serverless_min_capacity, temporal_aurora_serverless_max_capacity, temporal_aurora_instances are now used in the "aws_db_instance" and "temporal" modules respectively. [1] [2]

  • modules/aws_ecs/temporal/main.tf: The new variables temporal_aurora_engine_version, temporal_aurora_serverless_min_capacity, temporal_aurora_serverless_max_capacity, and temporal_aurora_instances are now used in the "temporal_aurora_rds" module. [1] [2] [3]

All the new configuration variables have been given their previous non-configurable values to keep full backwards compatibility.
The rds_instance_storage_encrypted variable was defaulted to false because that's the inherited value from the AWS Provider.

Copy link
Contributor

@roberto-retool roberto-retool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the extra configurability added here!

@anna-yn anna-yn merged commit b750d99 into tryretool:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants