Add configuration variables for Retool & Temporal RDS clusters/instances #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the configurability of the AWS ECS module for the Temporal Aurora and RDS instance. The changes introduce new variables to allow customization of engine version, serverless capacity, and instances for Temporal Aurora, as well as enabling storage encryption for the RDS instance.
Key changes include:
New Variables Introduced:
modules/aws_ecs/temporal/variables.tf
andmodules/aws_ecs/variables.tf
: Introduced new variablestemporal_aurora_engine_version
,temporal_aurora_serverless_min_capacity
,temporal_aurora_serverless_max_capacity
,temporal_aurora_instances
, andrds_instance_storage_encrypted
to allow customization of Temporal Aurora and RDS instance settings. [1] [2] [3]Use of New Variables:
modules/aws_ecs/main.tf
: The new variablesrds_instance_storage_encrypted
andtemporal_aurora_engine_version
,temporal_aurora_serverless_min_capacity
,temporal_aurora_serverless_max_capacity
,temporal_aurora_instances
are now used in the "aws_db_instance" and "temporal" modules respectively. [1] [2]modules/aws_ecs/temporal/main.tf
: The new variablestemporal_aurora_engine_version
,temporal_aurora_serverless_min_capacity
,temporal_aurora_serverless_max_capacity
, andtemporal_aurora_instances
are now used in the "temporal_aurora_rds" module. [1] [2] [3]All the new configuration variables have been given their previous non-configurable values to keep full backwards compatibility.
The
rds_instance_storage_encrypted
variable was defaulted tofalse
because that's the inherited value from the AWS Provider.