Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add temporal_ecs_task_resource_map variable #53

Conversation

briferz
Copy link
Contributor

@briferz briferz commented Jul 26, 2024

This pull request includes changes to the Terraform configuration files modules/aws_ecs/main.tf and modules/aws_ecs/variables.tf. The changes introduce a new variable temporal_ecs_task_resource_map and use it to configure the resources for Temporal services in the ECS module. The most important changes are:

  • modules/aws_ecs/variables.tf: Introduced a new variable temporal_ecs_task_resource_map of type map that specifies the amount of CPU and memory provisioned for each Temporal task. The map keys include frontend, history, matching, and worker, each associated with an object specifying cpu and memory values.
  • modules/aws_ecs/main.tf: Added a new temporal_services_config block in the module "temporal" block. This new block uses the temporal_ecs_task_resource_map variable to set the CPU and memory for each Temporal service. Each service also has its own request_port and membership_port specified.

Copy link
Contributor

@roberto-retool roberto-retool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for surfacing this variable!

@roberto-retool roberto-retool merged commit 1ca1d66 into tryretool:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants