Skip to content

Score MIPI CSI and DSI pin labels#123

Open
jjoanna2-debug wants to merge 8 commits into
tscircuit:mainfrom
jjoanna2-debug:codex/mipi-csi-dsi-pin-labels
Open

Score MIPI CSI and DSI pin labels#123
jjoanna2-debug wants to merge 8 commits into
tscircuit:mainfrom
jjoanna2-debug:codex/mipi-csi-dsi-pin-labels

Conversation

@jjoanna2-debug

@jjoanna2-debug jjoanna2-debug commented May 11, 2026

Copy link
Copy Markdown

Summary

  • add a narrow MIPI CSI/DSI lane-label scorer guard for aliases such as CSI_D0P, CSI_D0N, DSI_CLKP, DSI_CLKN, CSI_CKP, and DSI_CKN
  • preserve indexed, underscore-separated, hyphen-separated, CK-shorthand, D-PHY, bare MIPI lane, and polarity-first lane forms such as MIPI_CSI0_D0_P, MIPI_DSI0_CLK_N, MIPI-CSI1-D2-P, MIPI-DSI1-CLK-P, MIPI_DSI2_CK_N, MIPI_DPHY_D3_N, MIPI_D0_P, MIPI_CSI_DP0, and MIPI_DSI_DN1 before the generic numeric fallback
  • bound the lane-token matcher so family-only, generic control labels, and lane-token prefixes with extra suffixes do not score as real differential lane aliases
  • add raw Circuit JSON regression coverage for generic chip/header pins carrying compact, indexed, hyphenated, CK-style, D-PHY, bare-MIPI, and polarity-first CSI/DSI lane hints

Review signal

  • This is a scoped CSI/DSI/D-PHY lane matcher, not a broad digit-bearing label promotion.
  • The matcher requires a MIPI/CSI/DSI/D-PHY family signal plus a real lane/polarity token at the end of the label, so false positives like MIPI_D0POWER, MIPI_DSI_CLKPWR, MIPI_DSI_CLKNRESET, MIPI_DSI_CLK_N_EN, and MIPI_CSI_D0_P_AUX stay below lane score.
  • The regression fixture proves both generated NET names and readable pin entries preserve the lane hints across compact, separator-heavy, and polarity-first forms.

Validation

  • npx --yes bun test tests/test4-mipi-csi-dsi-pin-labels.test.ts
  • npx biome check lib/scorePhrase.ts tests/test4-mipi-csi-dsi-pin-labels.test.ts
  • npx tsc --noEmit
  • npx --yes bun run build
  • git diff --check

/claim #4

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jjoanna2-debug jjoanna2-debug force-pushed the codex/mipi-csi-dsi-pin-labels branch from 444c4cc to 601eaaa Compare May 12, 2026 00:50
Signed-off-by: jjoanna2-debug <273834277+jjoanna2-debug@users.noreply.github.com>
@jjoanna2-debug jjoanna2-debug force-pushed the codex/mipi-csi-dsi-pin-labels branch from 601eaaa to 2c80d64 Compare May 12, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant