Skip to content

Fix readable labels for numbered pins#686

Open
TeedsK wants to merge 1 commit into
tscircuit:mainfrom
TeedsK:fix-readable-pin-labels
Open

Fix readable labels for numbered pins#686
TeedsK wants to merge 1 commit into
tscircuit:mainfrom
TeedsK:fix-readable-pin-labels

Conversation

@TeedsK

@TeedsK TeedsK commented May 31, 2026

Copy link
Copy Markdown

Summary

  • score known pin-label vocabulary before applying the generic digit penalty, so labels such as GPIO14 and UART_TX1 can beat pin14
  • make score matching case-insensitive for the existing vocabulary
  • omit missing passive footprints from COMPONENT_PINS headers instead of printing undefined
  • add regression coverage for digit-bearing pin labels and no-footprint passive headers

Fixes #4
/claim #4

Verification

  • npx --yes bun@latest test
  • ./node_modules/.bin/biome check .
  • npx --yes bun@latest run build
  • ./node_modules/.bin/tsc --noEmit
  • git diff --check

AI-assisted with OpenAI Codex; I inspected the diff and ran the checks above before opening this PR.

TeedsK commented May 31, 2026

Copy link
Copy Markdown
Author

All four GitHub Actions checks are green on 7696e756bffb0f48391cd12a5a7af2770596d118 (Dependency Check, Bun Test, Type Check, Format Check). This is ready for review; happy to tighten or expand the regression coverage if you want the scope adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined in readable netlists, pin labels are too short, just "pin14" instead of full pin labels

1 participant