fix: number msop and son right-column pins counterclockwise#678
Open
chayan-1906 wants to merge 4 commits into
Open
fix: number msop and son right-column pins counterclockwise#678chayan-1906 wants to merge 4 commits into
chayan-1906 wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msopandsonnumbered their right-column pins top→bottom (same direction as the left column), instead of the standard counterclockwise order every other dual-row footprint in this repo uses (soic/dfn/sop8viagetCcwSoicCoords,tssop/ssopin their own coord functions). The pad positions were fine — only the pin→pad mapping was mirrored, so pins 5↔8 / 6↔7 (msop8, son8), 4↔6 (son6), 6↔10 / 7↔9 (msop10) would route to the wrong nets. This never showed in SVG snapshots because pin numbers aren't rendered there.Fixes #677
Expected vs actual (msop8, default params)
Changes
src/fn/msop.ts/src/fn/son.ts: one-line fix in the coord helpers — the right column now runs bottom→top (vssopalready worked around this same helper by remapping pin numbers, which is why it wasn't affected)tests/msop.test.ts/tests/son.test.ts: added counterclockwise-numbering assertions for msop8, son8, son6 so this can't regress invisibly againTesting
main(verified by running them against the unfixed code) and pass with the fixbun run buildandbunx biome formatclean🤖 Generated with Claude Code