use square pin1 pad for electrolytic capacitor#680
Merged
seveibar merged 1 commit intoJul 4, 2026
Conversation
rushabhcodes
changed the title
rushabhcodes
requested review from
a team,
Abse2001,
ShiboSoftwareDev and
mohan-bee
seveibar
changed the title
seveibar
approved these changes
Jul 4, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
see my title change, kicad parity isn't a goal, just a way to check results
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The generated electrolytic footprint used circular pads for both pins, while the matching KiCad footprint uses a square pad for pin 1 as its polarity marker. This caused an 8.35% pad-area difference in the parity visualization.
Impact
Electrolytic footprints now match the KiCad pin-1 pad geometry without changing pitch, drill size, courtyard, or pin-2 geometry.
Validation
bun test tests/electrolytic.test.ts tests/kicad-parity/electrolytic_kicad_parity.test.tsbun run build