fix MSOP KiCad pad parity#681
Merged
rushabhcodes merged 1 commit intoJul 3, 2026
Merged
Conversation
rushabhcodes
changed the title
imrishabh18
approved these changes
Jul 3, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The MSOP coordinate helper accepted the package body width but ignored it, placing every pad row at a hard-coded
±2 mm. For the KiCad MSOP-8 footprint, this put both rows 0.1125 mm too close to the package center.Impact
MSOP pad placement now scales correctly with package and pad dimensions, and the MSOP-8 parity visualization has complete pad overlap.
Validation
bun test tests/msop.test.ts tests/kicad-parity/msop8_kicad_parity.test.tsbun run build