Skip to content

fix: number sot723 pins to match the datasheet (pins 1↔3 were swapped) #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chayan-1906 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: number sot723 pins to match the datasheet (pins 1↔3 were swapped) #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbfb7ec
fix: number sot723 pins to match the datasheet (1 top-left, 3 right)
chayan-1906 Jul 3, 2026
8ff2ccc
test: lock sot723 pin numbering to pad positions
chayan-1906 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fn/sot723.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ export const getCcwSot723Coords = (parameters: {
const { pn, w, h, pl, p } = parameters

if (pn === 1) {
return { x: p, y: 0 }
return { x: -p, y: 0.4 }
}
if (pn === 2) {
return { x: -p, y: -0.4 }
}
return { x: -p, y: 0.4 }
return { x: p, y: 0 }
}

export const sot723WithoutParsing = (
Expand Down
16 changes: 16 additions & 0 deletions tests/sot723.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,19 @@ test("sot723", () => {
const svgContent = convertCircuitJsonToPcbSvg(soup)
expect(svgContent).toMatchSvgSnapshot(import.meta.path, "sot723")
})

test("sot723 numbers pins like the datasheet: 1 top-left, 2 bottom-left, 3 right", () => {
const circuitJson = fp.string("sot723").circuitJson() as any[]
const pad = (pin: string) =>
circuitJson.find(
(el) => el.type === "pcb_smtpad" && el.port_hints?.[0] === pin,
)
// KiCad SOT-723 (Toshiba datasheet): pins 1 and 2 stack on the left
// (1 on top), pin 3 sits alone on the right, like sot23/sot323
expect(pad("1").x).toBeCloseTo(-0.575)
expect(pad("1").y).toBeCloseTo(0.4)
expect(pad("2").x).toBeCloseTo(-0.575)
expect(pad("2").y).toBeCloseTo(-0.4)
expect(pad("3").x).toBeCloseTo(0.575)
expect(pad("3").y).toBeCloseTo(0)
})
Loading