allow fixedPosition for chips#119
Closed
Sang-it wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
3003127 to
70cc068
Compare
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
70cc068 to
3c3d39f
Compare
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
3c3d39f to
e5cb203
Compare
seveibar
reviewed
Jun 4, 2026
| } | ||
| } | ||
| } | ||
| return pinToNetworkMap |
Contributor
There was a problem hiding this comment.
Doesnt need to be an instance method (seperate file/function)
seveibar
reviewed
Jun 4, 2026
| componentId: `partition_${group.partitionIndex}`, | ||
| pads, | ||
| availableRotationDegrees: [0] as Array<0 | 90 | 180 | 270>, // Keep partitions unrotated | ||
| availableRotationDegrees: [0] as Array<0 | 90 | 180 | 270>, |
seveibar
reviewed
Jun 4, 2026
| absoluteCenter: { x: chip.fixedPosition.x, y: chip.fixedPosition.y }, | ||
| }) | ||
|
|
||
| this.activeSubSolver.packedComponents.push({ |
Contributor
There was a problem hiding this comment.
you can't modify an activeSubSolver
Contributor
There was a problem hiding this comment.
you can modify the constructor to accept other arguments
seveibar
reviewed
Jun 4, 2026
| } | ||
|
|
||
| if (this.activeSubSolver.solved) { | ||
| // Apply the packing result to create the layout |
Contributor
There was a problem hiding this comment.
why are you removing comments and increasing the size of the diff- keep your PRs minimal and to the point, i don't want to have to evaluate the value of the comment when reading the PR
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
8eab408 to
4af87d7
Compare
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
4af87d7 to
da1fe78
Compare
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
da1fe78 to
5454567
Compare
Sang-it
force-pushed
the
implement-fixed-position-support
branch
from
4f656ea to
f322f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.