examples: implement dc #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implemented bc.
|
@seija-amanojaku if something is interesting enough but not fully implemented, there is no reason to make it a draft. Just leave a TODO for not yet implemented things and say it's ready for review. Rest of the stuff can be always implemented as separate PRs (even by somebody else who has more time and motivation). |
|
@seija-amanojaku it seems to be working on my machine. Alright, let's get it merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a fairly long implementation for dc, with bignum support, and it should be rather portable (although some platforms may require an actual
getcharimplementation, heap functions andmemset/memcpyI'm marking it as a draft mainly because the scale/decimal point feature isn't implemented yet, but integer math actually works quite well