Parse numbers as either integer or floating type #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added a missing punctuation
also renamed floating -> decimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse numbers as both an integer and a floating point number. Include a
number_typefield to indicate which of the two is the best match, for those that care, for those that don't, they can just use the floating point (double) value unconditionally for simplicity. This reduces the potential loss of precision when parsing large numbers, for example,9007199254740993would be parsed as9007199254740992.0, however now it is correctly parsed as9007199254740993(if theintegerfield is used).PS. Also fixed a small typo in the README