Illustrate partialling errors of derived inputs in tt_function
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
This PR reproduces the partialling error of inputs that would be derived function in the
tt_function. Its easiest to start with an example. Suppose:policy_inputisx_mx_yas a scalar when requesting thett_functiontt_functionwill still ask forx_yas an input, i.e. the partialling that should have happened in step 2 did not happenThe reason is connected to the problems we had when building templates: Derived functions are not created when there is no input data to create them from. In particular, this line in
with_processed_params_and_scalarsis problematic, because there is no nodex_ywhen creating thett_functionin the example above:From having a quick look at the code, it seems like it wouldn't break anything to carry over any scalar in the processed data through to
with_partialled_params_and_scalars(i.e. not just those inwithout_tree_logic_and_with_derived_functions).