Event Emission from viewmodel to Event Manager and Rename Project Flow Update #645
Conversation
| @@ -7,6 +7,7 @@ dismiss the modal correctly. | |||
| <script lang="ts"> | |||
| import { onMount } from 'svelte'; | |||
|
|
|||
| export let onSubmit: () => void = () => {}; | |||
There was a problem hiding this comment.
I’ve initialized it as an empty function to ensure it's optional—other components using this one won’t need any changes, and everything will work as before if the function isn’t needed.
| return this._projectFlow.value!.find((item) => item.id === id); | ||
| } | ||
| } | ||
|
|
||
| export const projectDataViewModel = new ProjectDataViewModel(); | ||
| const appContext = new AppContext(); | ||
| export const projectDataViewModel = new ProjectDataViewModel(appContext.actionManager); |
There was a problem hiding this comment.
This is not correct. appContext should be achieved from the context of Svelte.
Then we will set projectDataViewModel into the context for internal component used.
| this.renamingProjectIdFlow.value = id; | ||
| this.actionManager.setOneTimeAction(OneTimeAction.ProjectAction.RenameCurrentProject(newName)); |
There was a problem hiding this comment.
This is not correct. setRenamingProject means set the target project for renaming, not setting the project name. Set project name is done by setProjectName
| @@ -27,6 +28,8 @@ onMount(() => { | |||
| function onKeyDown(event: KeyboardEvent) { | |||
| if (event.key === 'Escape') { | |||
| dismiss(); | |||
| } else if (event.key === 'Enter') { | |||
There was a problem hiding this comment.
I don't think we should handle this key inside the modal component container. This key should be captured explicitly by the content of the modal.
Changes Summary:
Event Emission from
viewmodel.tsto Event Manager:viewmodel.tsto the Event Manager. Since I’m still getting familiar with the codebase, I'm not entirely sure if this is the best approach yet, but it's a start. Let me know if my implementation looks correct or if there’s a better way to handle this.Rename Project Flow Update:
Added an
onSubmitevent to theNoBackgroundModal, which is now bound to the Enter key. This change allows users to submit the new project name by pressing Enter, while pressing ESC will cancel the renaming process.Why do I do that? While testing the existing rename flow, I found it a bit confusing. Specifically, when the
RenameProjectModalpopped up, pressing ESC or clicking outside the modal would dismiss it, but the new project name would still be updated. Meanwhile, pressing Enter didn’t do anything at all. In most UI flows, ESC should cancel the action without making changes, and Enter should confirm it. That’s why I added theonSubmitmethod. Now, pressing Enter submits the new name and updates the project name, while ESC properly cancels without making any changes. This update should make the renaming process more intuitive and predictable.