Skip to content

fix: close stdin on spawned processes to prevent hanging #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuannvm merged 5 commits into from
Apr 10, 2026
Merged

fix: close stdin on spawned processes to prevent hanging #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae5e66e
fix: close stdin on spawned processes to prevent hanging
tuannvm Apr 10, 2026
ee759e7
fix: use optional chaining on stdin.end() for defensive null safety
tuannvm Apr 10, 2026
1a1b0c1
fix(security): update @hono/node-server to 1.19.13
tuannvm Apr 10, 2026
15891fe
fix(ci): allow cursor-agent to fail gracefully in code-review
tuannvm Apr 10, 2026
b9f9bb9
ci: remove cursor code review workflow
tuannvm Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 0 additions & 146 deletions .github/workflows/cursor.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions src/utils/command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ export async function executeCommand(

const child = spawn(file, escapedArgs, spawnOptions);

// Close stdin to prevent processes like codex exec from waiting forever for input
// When spawned with stdio pipe, codex waits for stdin EOF that never arrives
child.stdin?.end();

let stdout = '';
let stderr = '';
let stdoutTruncated = false;
Expand Down Expand Up @@ -164,6 +168,10 @@ export async function executeCommandStreaming(

const child = spawn(file, escapedArgs, spawnOptions);

// Close stdin to prevent processes like codex exec from waiting forever for input
// When spawned with stdio pipe, codex waits for stdin EOF that never arrives
child.stdin?.end();

let stdout = '';
let stderr = '';
let stdoutTruncated = false;
Expand Down
Loading