Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining fixes to install script #2

Merged
merged 4 commits into from
Mar 3, 2019
Merged

Remaining fixes to install script #2

merged 4 commits into from
Mar 3, 2019

Conversation

ar13pit
Copy link

@ar13pit ar13pit commented Feb 2, 2019

No description provided.

MatthijsBurgh
MatthijsBurgh reviewed Feb 2, 2019
View reviewed changes
MatthijsBurgh
MatthijsBurgh previously approved these changes Feb 4, 2019
View reviewed changes
@ar13pit
Copy link
Author

ar13pit commented Feb 12, 2019

@MatthijsBurgh review needed.
I changed the return to exit as in https://github.com/tue-robotics/tue-env-targets/blob/master/kaldi/install.bash#L69 the script is being executed instead of being sourced

@ar13pit
Copy link
Author

ar13pit commented Mar 3, 2019

I am merging this as it has been there for review for quite sometime.

@ar13pit ar13pit merged commit 2cda16f into develop Mar 3, 2019
@ar13pit ar13pit deleted the fix/install branch March 3, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthijsBurgh MatthijsBurgh MatthijsBurgh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ar13pit @MatthijsBurgh