Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll SingleChoicePrompt when larger than terminal height #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

finnvoor
Copy link

@finnvoor finnvoor commented Feb 21, 2025

Hi! Love the project, I'm hoping to retire SwiftTUI in favor of Noora for tools like xcc. There's just a few things holding me back from switching, so here's a PR for one of them:

CleanShot.2025-02-21.at.18.11.51.mp4

When the number of options in SingleChoicePrompt exceeds the number of rows in your terminal, it will now render as a scrolling list.

Currently Renderer ends all renders with a newline. It would be nice if this was changed so the list could take the full terminal height, but I left this for a future PR to keep this one simple. Please let me know if you have any feedback!

Remaining:

  • Add tests

@finnvoor finnvoor force-pushed the main branch 4 times, most recently from 5ad31d7 to aa4ab1f Compare February 21, 2025 18:31
@finnvoor finnvoor marked this pull request as ready for review February 23, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant