Skip to content

feat: extend the BuildAction to allow setting the architecture #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −1
Open

feat: extend the BuildAction to allow setting the architecture #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sources/XcodeGraph/Models/BuildAction+Architectures.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
extension BuildAction {
public enum Architectures: Equatable, Codable, Sendable {
case matchRunDestination
case universal
case useTargetSettings
}
Comment on lines +2 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add types in extensions to keep ease symbol resolution to the compiler.

}
5 changes: 4 additions & 1 deletion Sources/XcodeGraph/Models/BuildAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public struct BuildAction: Equatable, Codable, Sendable {
public var parallelizeBuild: Bool
public var runPostActionsOnFailure: Bool
public var findImplicitDependencies: Bool
public var overrideArchitectures: Architectures

// MARK: - Init

Expand All @@ -19,14 +20,16 @@ public struct BuildAction: Equatable, Codable, Sendable {
postActions: [ExecutionAction] = [],
parallelizeBuild: Bool = true,
runPostActionsOnFailure: Bool = false,
findImplicitDependencies: Bool = true
findImplicitDependencies: Bool = true,
overrideArchitectures: Architectures = .useTargetSettings
) {
self.targets = targets
self.preActions = preActions
self.postActions = postActions
self.parallelizeBuild = parallelizeBuild
self.runPostActionsOnFailure = runPostActionsOnFailure
self.findImplicitDependencies = findImplicitDependencies
self.overrideArchitectures = overrideArchitectures
}
}

Expand Down
14 changes: 14 additions & 0 deletions Tests/XcodeGraphTests/Models/BuildAction.ArchitecturesTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import Foundation
import XCTest

@testable import XcodeGraph

final class BuildActionArchitecturesTests: XCTestCase {
func test_codable() {
// Given
let subject = BuildAction.Architectures.universal

// Then
XCTAssertCodable(subject)
}
}
Comment on lines +6 to +14
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Expand test coverage for all enum cases.

The test correctly verifies Codable conformance but only covers the .universal case. Consider testing all cases to ensure comprehensive coverage.

final class BuildActionArchitecturesTests: XCTestCase {
    func test_codable() {
-        // Given
-        let subject = BuildAction.Architectures.universal
-
-        // Then
-        XCTAssertCodable(subject)
+        // Test all cases for Codable conformance
+        XCTAssertCodable(BuildAction.Architectures.matchRunDestination)
+        XCTAssertCodable(BuildAction.Architectures.universal)
+        XCTAssertCodable(BuildAction.Architectures.useTargetSettings)
+    }
+    
+    func test_equatable() {
+        XCTAssertEqual(BuildAction.Architectures.universal, BuildAction.Architectures.universal)
+        XCTAssertNotEqual(BuildAction.Architectures.universal, BuildAction.Architectures.matchRunDestination)
+        XCTAssertNotEqual(BuildAction.Architectures.universal, BuildAction.Architectures.useTargetSettings)
    }
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
final class BuildActionArchitecturesTests: XCTestCase {
func test_codable() {
// Given
let subject = BuildAction.Architectures.universal
// Then
XCTAssertCodable(subject)
}
}
final class BuildActionArchitecturesTests: XCTestCase {
func test_codable() {
// Test all cases for Codable conformance
XCTAssertCodable(BuildAction.Architectures.matchRunDestination)
XCTAssertCodable(BuildAction.Architectures.universal)
XCTAssertCodable(BuildAction.Architectures.useTargetSettings)
}
func test_equatable() {
XCTAssertEqual(BuildAction.Architectures.universal, BuildAction.Architectures.universal)
XCTAssertNotEqual(BuildAction.Architectures.universal, BuildAction.Architectures.matchRunDestination)
XCTAssertNotEqual(BuildAction.Architectures.universal, BuildAction.Architectures.useTargetSettings)
}
}
🤖 Prompt for AI Agents 
In Tests/XcodeGraphTests/Models/BuildAction.ArchitecturesTests.swift between
lines 6 and 14, the Codable test only covers the .universal case of the
BuildAction.Architectures enum. To fix this, expand the test to iterate over all
enum cases and verify Codable conformance for each one, ensuring comprehensive
test coverage of all possible values.

Loading