Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement converter refactor #95

Merged
merged 17 commits into from
May 5, 2020
Merged

Placement converter refactor #95

merged 17 commits into from
May 5, 2020

Conversation

hechth
Copy link
Contributor

@hechth hechth commented Apr 27, 2020

  • Refactored convertIfcObjectPlacement to make code more readable.

@hechth hechth added the enhancement New feature or request label Apr 27, 2020
@hechth hechth requested a review from pjanck April 27, 2020 07:12
pjanck
pjanck suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really hard to do a review, when the identation changed ... This is definitely not yet all of it ...

@hechth
Copy link
Contributor Author

hechth commented Apr 30, 2020

Resolved all requests except the one regarding convertIfcObjectPlacement as it requires more actions

@hechth hechth requested a review from pjanck April 30, 2020 12:56
@hechth
Copy link
Contributor Author

hechth commented Apr 30, 2020

Fixed all requested changes except for convertBoundedCurveDistAlongToPoint3D

pjanck
pjanck approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of changes to be made, but will probably be addressed in later overhauls.

Core/src/IfcGeometryConverter/PlacementConverter.h
void convertIfcDirection(
const std::shared_ptr<typename IfcEntityTypesT::IfcDirection>& ifcDirection,
carve::geom::vector<3>& direction)
carve::geom::vector<3> convertIfcDirection(const EXPRESSReference<typename IfcEntityTypesT::IfcDirection>& ifcDirection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done everywhere. Change std::shared_ptr<> with EXPRESSReference<>

@hechth hechth merged commit 1c7aa23 into tumcms:development May 5, 2020
@hechth hechth deleted the placement-converter-refactor branch May 12, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanck pjanck pjanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hechth @pjanck