e2e: Fix flaky network reset test on Windows #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acconut
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
internal/e2e/e2e_test.gofile. The change introduces a delay of 100 milliseconds because the e2e test occasionally failed on the Windows platform.internal/e2e/e2e_test.go: Added a 100-millisecond delay after encountering a fatal error to ensure proper timing in the test execution.Hint
An alternative solution could be to use
tcpConn.CloseWrite()between theconn.Write()and thetcpConn.Close().I did a tcpdump and it also sends a RST, but maybe it changes the purpose of this e2e test too much.