Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438
Problem
mo optimizeexits with code 1 during "App State Cleanup" when it hits a.savedStatedirectory that needs Full Disk Access (e.g.net.maxon.appinstaller.savedState). Withset -euo pipefail, the failingsafe_removestops the script instead of skipping the protected directory.Solution
Add
|| trueaftersafe_removecalls inopt_saved_state_cleanupandopt_cache_refresh, matching the Pipefail Safety pattern in CONTRIBUTING.md: