Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _isShown() method to private section #41220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohamadSalman11
Copy link
Contributor

Description

I’m not sure if this is an oversight or on purpose, but I think the _isShown() method should be moved to the private section since it’s marked as private, especially since in js/src/dropdown.js it’s correctly placed under the private section. Please let me know if I missed anything. I’d appreciate your feedback!

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants