Display red border around styled inputs when there are errors #9942
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements error state styling for input fields by utilizing the hasError prop to display a red border around invalid inputs.
- Modified
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/MultiItemBaseInput.tsxto use theme-based danger color for border whenhasErroris true - Potential issue: Error styling only applies when
hasItemis true, which may not show validation errors in empty states - Consider extending error state styling to all input states, not just when
hasItemis true
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
16
to
22
| ${({ hasError, hasItem, theme }) => | ||
| hasItem && | ||
| css` | ||
| background-color: ${theme.background.transparent.lighter}; | ||
| border-radius: 4px; | ||
| border: 1px solid ${theme.border.color.medium}; | ||
| border: 1px solid ${hasError ? theme.border.color.danger : theme.border.color.medium}; | ||
| `} |
There was a problem hiding this comment.
logic: Error styling only applies when hasItem is true. Consider if error state should be visible regardless of hasItem status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9778
Summary
hasErrorprop was simply ignored inStyledInputwhen it should have been used to flag the text input as invalid by displaying a red border around it.Screenshot
with action items -
without action items -