Openshift Updates #112
Closed
Openshift Updates #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding examples to the Open Policy Agent policies.
Fixed the following: 1. Better structure of the Installation flow with integration of YAML and Helm Chart in one flow and not different chapters. 2. Added all necessary changes for Openshift 4 where CRI-O is a must. 3. Added the necessary changes for the Defenders if they are deployed as a helm chart in Openshift 4.
|
@iansk this is ready to merge |
|
@iansk could you please look at merging this one as well? It's showing a conflict, not sure how to fix that. |
|
@automatecloud there is a merge conflict with this one. Can you fix? |
|
@sgordon46 i did a complete rewriting of the openshift installation back in May - July that should be merged before we merge all other openshift updates if you ask me? @iansk what can we do now? |
|
@automatecloud do you have a PR for those changes? |
|
@ryanchauvin no but i think we can use yours ? #148 |
|
Excellent work @automatecloud. I'm merging a variation of your work in this PR: #239 Also, thanks @ryanchauvin for additional follow-on fixes. Closing unmerged. |
iansk
pushed a commit
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following: