Multiple Changes: #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py - - Incremented minor version to 0.8.10 due to bug fixes. (latest release on github is 0.8.8) examples/readme - - Updated the documentation for FilteredStream class to reflect change to class. twitter_stream.py - - Removed .json() on line 185 as get_rules returns the appropriate object already. .json() was causing delete_all_rules to not work correctly and not error. - Added _has_params = True to FilteredStream class to allow adding expansions to tweet objects. Documentation in examples now reflects this.
|
Hi there! Thank You! I will have to write a few tests. Run it locally and merge and publish to PyPI. I'm working on it. |
|
@SolidHabu I merged the pull request despite not passing Gtihub WorkFlow Packages set in place. Firstly because I only plan to support One other reason the tests failed -- is that Github WorkFlow doesn't have individuals' credentials set in place in the form of Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py -
examples/readme -
twitter_stream.py -
Removed .json() on line 185 as get_rules returns the appropriate object already.
.json() was causing delete_all_rules to not work correctly and not error.
Added _has_params = True to FilteredStream class to allow adding expansions to
tweet objects. Documentation in examples now reflects this.