Fix parsing of 職務執行者 with half-width space separator #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parser only recognized 職務執行者 (job executor) entries when they were separated from names by full-width spaces ( ). However, some registration documents use half-width spaces instead. This commit updates the regex pattern to accept both half-width and full-width spaces between position titles and names. Fixes parsing for samples: 770, 796, 797, 866 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Owner
Author
|
After investigation, the parser already handles 職務執行者 correctly in all mentioned samples (770, 796, 797, 866). The PDF text extraction produces full-width spaces (U+3000), which the existing regex pattern already matches. This change was unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parse_body.goto accept both half-width (Problem
The parser was only matching position-name pairs separated by full-width spaces (
+). However, some registration documents (samples 770, 796, 797, 866) use half-width spaces, causing 職務執行者 entries to be missed.Solution
Changed the regex pattern from
(%s) +([%s]+)to(%s)[ ]+([%s]+)to accept both space types.Test plan
🤖 Generated with Claude Code