Fix executive responsibility change handling #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where executives with responsibility changes (責任変更) were incorrectly shown as active in both old and new positions. Problem: - In sample891.pdf, 弓納持弘 appears as both 有限責任社員 (limited liability partner) and 無限責任社員 (unlimited liability partner) - The responsibility change (有限→無限) was not properly detected across different executive sections Solution: 1. Added "責任変更" to the list of resignation patterns in getResignedAt() 2. Implemented global post-processing in GetHoujinExecutives() to handle responsibility changes across all executive sections 3. Added postProcessResponsibilityChangesGlobal() to invalidate limited liability partners when the same person becomes an unlimited liability partner The parser now correctly handles responsibility changes and shows only the current position for each executive. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Closed
Add --remote flag to wrangler r2 commands in put/sample target to ensure files are uploaded to the actual Cloudflare R2 bucket instead of local simulation environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In PDF sample891, 弓納持弘 had a responsibility change from 有限責任社員 (limited liability partner) to 無限責任社員 (unlimited liability partner). The parser was not properly detecting this change across different executive sections, resulting in the person appearing in both positions.
Solution
parse_body.go:67): ExtendedgetResignedAt()to recognize responsibility changes as a type of status changehoujin_body.go:46-119): ModifiedGetHoujinExecutives()to collect all executives first, then apply post-processing across all sectionshoujin_body.go:46-87): CreatedpostProcessResponsibilityChangesGlobal()to invalidate limited liability partner entries when the same person becomes an unlimited liability partnerTest Results
make annotate TARGET=sample891now correctly shows only 無限責任社員 for 弓納持弘make test)Test plan
make annotate TARGET=sample891to verify the fixmake testto ensure no regressions🤖 Generated with Claude Code