Skip to content

Fix infinite loop when nest selection runs non-interactively #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylerthecoder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix infinite loop when nest selection runs non-interactively #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c1a98
Fix infinite loop when nest selection runs non-interactively
tylerthecoder Feb 1, 2026
6496dba
Redirect stdin from /dev/tty in setup script for interactive install
tylerthecoder Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setups/owl/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ echo "Linked owl to ~/.local/bin/owl"
# Ensure ~/.local/bin is in PATH for this session
export PATH="$HOME/.local/bin:$PATH"

owl nest all
# Redirect stdin from /dev/tty to allow interactive nest selection even when piped from curl
owl nest all < /dev/tty

11 changes: 11 additions & 0 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,17 @@ fn get_nest() -> Setup {
}

fn switch_nest() -> Setup {
use std::io::IsTerminal;

if !std::io::stdin().is_terminal() {
eprintln!(
"{}",
"No nest configured and stdin is not interactive.".red()
Copy link

@cursor cursor bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message incorrectly claims no nest is configured

Low Severity

The error message "No nest configured and stdin is not interactive" is misleading when switch_nest() is called via owl nest switch with an existing nest configured. In this case, get_nest() succeeds (returning the current nest), then switch_nest() is called explicitly for switching. The TTY check fails, but the message incorrectly states "No nest configured" when a nest actually is configured. The message text doesn't accurately reflect all code paths that can trigger it.

Fix in Cursor Fix in Web

);
eprintln!("Run: {} < /dev/tty", "owl nest switch".cyan());
std::process::exit(1);
}

let mut config = get_config();

let nests = list_nests();
Expand Down
Loading