Skip to content

Commit

Permalink
Update lint config to account for ESM
Browse files Browse the repository at this point in the history
  • Loading branch information
dfreeman committed Nov 8, 2022
1 parent cd20907 commit ac0f1bc
Show file tree
Hide file tree
Showing 8 changed files with 294 additions and 125 deletions.
5 changes: 4 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Compiled output
/packages/*/lib
/packages/scripts/bin/lib
/packages/scripts/bin
/test-packages/*/lib

dist/
__fixtures__

# Ephemeral test applications
/test-packages/ephemeral
7 changes: 4 additions & 3 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,22 @@
"root": true,
"extends": ["eslint:recommended"],
"parserOptions": {
"ecmaVersion": 2020
"ecmaVersion": 2022,
"sourceType": "module"
},
"rules": {
"prefer-const": "off",
"require-yield": "off"
},
"overrides": [
{
"files": "*.js",
"files": ["*.js", "*.cjs", "*.mjs"],
"env": {
"node": true
}
},
{
"files": "*.ts",
"files": ["*.ts", "*.cts", "*.mts"],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint"],
"extends": [
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"@release-it-plugins/lerna-changelog": "^5.0.0",
"@release-it-plugins/workspaces": "^3.2.0",
"@types/yargs": "^17.0.10",
"@typescript-eslint/eslint-plugin": "^4.9.0",
"@typescript-eslint/parser": "^4.9.0",
"eslint": "^7.15.0",
"@typescript-eslint/eslint-plugin": "^5.42.1",
"@typescript-eslint/parser": "^5.42.1",
"eslint": "^8.27.0",
"prettier": "^2.1.1",
"release-it": "^15.5.0",
"typescript": "^4.7.4"
Expand Down
20 changes: 5 additions & 15 deletions test-packages/js-glimmerx-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
"copy-webpack-plugin": "^5.1.1",
"css-loader": "^3.4.2",
"eslint": "^6.8.0",
"eslint-config-prettier": "^6.10.1",
"eslint-plugin-prettier": "^3.1.2",
"file-loader": "^6.0.0",
"glob": "7.1.6",
"html-webpack-plugin": "^4.0.4",
Expand All @@ -47,33 +45,25 @@
"webpack-dev-server": "^3.10.3"
},
"eslintConfig": {
"parser": "babel-eslint",
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"ecmaVersion": 2022,
"sourceType": "module",
"ecmaFeatures": {
"impliedStrict": true
}
},
"rules": {
"no-unused-vars": "off"
},
"env": {
"browser": true
},
"plugins": [
"@glimmerx",
"prettier"
],
"extends": [
"eslint:recommended",
"plugin:prettier/recommended"
],
"ignorePatterns": [
"dist/",
"node_modules/",
"!.*"
],
"rules": {
"@glimmerx/template-vars": "error"
},
"overrides": [
{
"files": [
Expand Down
1 change: 0 additions & 1 deletion test-packages/ts-ember-app/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ module.exports = {
'lib/*/index.js',
'server/**/*.js',
],
parser: 'babel-eslint',
parserOptions: {
sourceType: 'script',
},
Expand Down
1 change: 0 additions & 1 deletion test-packages/ts-ember-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"@types/ember-resolver": "~5.0.10",
"@types/ember__test-helpers": "~2.6.1",
"@types/qunit": "^2.11.1",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^2.4.1",
"ember-cli": "~4.4.0",
Expand Down
4 changes: 1 addition & 3 deletions test-packages/ts-glimmerx-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
"@glint/core": "^0.9.7",
"@glint/environment-glimmerx": "^0.9.7",
"@types/qunit": "^2.9.1",
"@typescript-eslint/eslint-plugin": "^4.9.0",
"@typescript-eslint/parser": "^4.9.0",
"babel-loader": "^8.1.0",
"clean-webpack-plugin": "^3.0.0",
"copy-webpack-plugin": "^5.1.1",
Expand All @@ -58,7 +56,7 @@
"eslintConfig": {
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2019,
"ecmaVersion": 2021,
"sourceType": "module"
},
"env": {
Expand Down
Loading

0 comments on commit ac0f1bc

Please sign in to comment.