SkunkException: Just constructed an unknown completion 'SELECT' when using Amazon Redshift #1234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Amazon Redshift with Skunk
v0.6.4, we're gettingSkunkException: Just constructed an unknown completion 'SELECT'messages logged after runningSELECTqueries.The modifications in
CompletionandCommandCompleteare variations on the protocol to better support Redshift, which apparently doesn't return a count for aSELECTstatement. The protocol documentation appears to say it should:but comments in the JDBC driver state:
so clients should probably be prepared to handle this?
Practically speaking, true Postgres servers do return row counts, but Redshift does not.
I'm not sure whether the other
CommandCompletecases with required counts (Delete,Update,Insert,Copy, andMerge) should also be adjusted accordingly. I haven't tried those types of queries yet so I'm not sure whether Skunk emits the same warning.