Improve RenameExpectSameToExpect rule to apply to expect.all
#242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RenameExpectToExpectSamescalafix rule rewritesexpect(...)calls toexpect.same, but misses several other rewrite opportunities:expect.all. Users relying heavily onexpect.allhave no easy migration rule, and poor error messages from it.&&and||. Users can wrap these in clues, but their errors and code would be cleaner if these were rewritten to weaver'sandandor.===This changeset amends the rule to apply to:
expect.allby rewriting equality assertions intoexpect.same(...).and(...)calls===by rewriting it toexpect.eql.&&and||by rewriting them toexpect(...).and(expect(...))expect(if cond a else b)by rewriting it toif cond expect(a) else expect(b))expect(a match { case b => c })by rewriting it toa match { case b => expect(c) }It also improves
AddClueToExpectto add clues to negated statements and type applications.