Skip to content

Deprecate diff #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Deprecate diff #55

merged 1 commit into from
Apr 11, 2025

Conversation

MDLC01
Copy link
Collaborator

@MDLC01 MDLC01 commented Mar 22, 2025

diff was meant to be deprecated since the addition of partial in typst/typst#3211. This was indicated in the Typst 0.11.0 changelog.

@laurmaedje
Copy link
Member

I intentionally didn't deprecate diff right away in #44 because there was some pushback and I wanted to at least have one more discussion about it. I've asked about consensus on Discord now, if it exists I'm fine with this.

@mkorje
Copy link
Collaborator

mkorje commented Apr 11, 2025

Given the consensus on Discord, I think it should be fine to go ahead with this.

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Apr 11, 2025

Was there really a consensus? If so, what was the conclusion regarding other related symbols?

@Enivex
Copy link
Collaborator

Enivex commented Apr 11, 2025

I would call it a consensus yes. Which other symbols are you referring to?

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Apr 11, 2025

The upright lower case Latin letter d, currently available as dif.

@Enivex
Copy link
Collaborator

Enivex commented Apr 11, 2025

I think that is a separate question that I'm not sure there is a consensus on yet

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Apr 11, 2025

If at least there is a consensus regarding diff, let's proceed with this PR.

@MDLC01 MDLC01 merged commit fa0d633 into typst:main Apr 11, 2025
1 check passed
@MDLC01 MDLC01 deleted the deprecate-diff branch April 11, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants