Avoid Enum.join when working with raw binaries#17
Open
jbowtie wants to merge 1 commit intotyre:masterfrom
Open
Avoid Enum.join when working with raw binaries#17jbowtie wants to merge 1 commit intotyre:masterfrom
jbowtie wants to merge 1 commit intotyre:masterfrom
Conversation
|
I tested this fix and it works 👍 thanks @jbowtie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Elixir 1.6 two tests fail -- this is because Enum.join is converting items to UTF-8 strings.
This pull request uses iodata_to_binary and list_to_bin instead of Enum.join when calling zlib since we are working with raw binary data.