Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require JDK 17 as the minimum version to run NullAway #1170

Open
msridhar opened this issue Mar 19, 2025 · 0 comments
Open

Require JDK 17 as the minimum version to run NullAway #1170

msridhar opened this issue Mar 19, 2025 · 0 comments

Comments

@msridhar
Copy link
Collaborator

msridhar commented Mar 19, 2025 •
edited
Loading

Error Prone has required JDK 17 since Sept. 2024 (version 2.32.0). NullAway currently still runs on JDK 11. Requiring JDK 17 could let us do some cleanup:

  1. Text blocks would ease writing of tests.
  2. Eventually, better support for reading type-use annotations from bytecodes may be ported back to JDK 17 (https://bugs.openjdk.org/browse/JDK-8346471). If we could rely on this fix, we could delete a lot of messy and tricky code.
  3. We could also use features like records and pattern matching instanceof to clean up the code more.

Nothing urgent, but we should figure out when to make this transition. Maybe Sept. 2025 would be a good time?
@msridhar msridhar mentioned this issue Mar 24, 2025
Merged
msridhar added a commit that referenced this issue Mar 24, 2025
@msridhar
Update to Error Prone 2.37.0 (#1169)
Loading
Loading status checks…
685065a 
We suppress some warnings on tests as they will be much easier to fix
with text blocks, which we can only use once we require JDK 17 (see
#1170).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msridhar