Allow predicates to work with more than one partition #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified reader._apply_predicate_to_row_groups to filter row_groups when all of the predicate fields are covered by the partition fields. However, still doesn't do any filtering if one or more of the predicate fields isn't also a partition field. Added some tests to cover new functionality. Hopefully addresses issue uber#487.
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 85.77% 85.87% +0.10%
==========================================
Files 79 79
Lines 4190 4192 +2
Branches 665 667 +2
==========================================
+ Hits 3594 3600 +6
+ Misses 494 490 -4
Partials 102 102
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified reader._apply_predicate_to_row_groups to filter row_groups when all of the predicate fields are covered by the partition fields. However, still doesn't do any filtering if one or more of the predicate fields isn't also a partition field. Added some tests to cover new functionality.
Hopefully addresses issue #487.