docs(best-shell-practices): update instructions and screenshots for Konsole#453
docs(best-shell-practices): update instructions and screenshots for Konsole#453Wittusus wants to merge 6 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the 'Best Shell Practices' documentation to align with the actual default terminal environment provided by Bazzite. By correcting the terminal name, navigation paths, and visual aids, the documentation now provides accurate guidance for users looking to configure their shell settings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect that Konsole is now the default terminal for Bazzite, replacing Ptyxis. The changes include updated instructions for changing the shell and new screenshots. Feedback was provided regarding a typo in the text, the need to update the corresponding Czech translation for consistency, and a recommendation to host images locally within the repository's image folder using absolute paths and descriptive alt text for better accessibility and robustness.
Remove duplicated word Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…sync cs translation
|
I did the change so the docs follow Bazzite 44 newest changes which removed Ptyxis as the default terminal |
|
This is a good change. I might make adjustments to have both examples since GNOME images still ship Ptyxis. I'll review this later when I have more time and it will probably get merged regardless. Thanks! |
|
@nicknamenamenick if it's planned for the Gnome version to include Ptyxis in the future, let me know, I can make the adjustments to include both |
GNOME images have it now and will probably for the unforeseeable future. Even the upstream Fedora Silverblue uses Ptyxis. |
|
I could probably finish this, but only in English since language translations are something I'm not comfortable doing personally. |
Summary
The default terminal on Bazzite (KDE variant) is Konsole, not Ptyxis. This PR corrects the documentation to reflect that.
Changes
Testing
Verified locally with `just mkdocs serve`."