Open
Conversation
Contributor
Author
|
sidkama
approved these changes
May 19, 2025
sidkama
left a comment
sidkama
left a comment
There was a problem hiding this comment.
more of a design question - do we truly need a user count? from testing the count seemed to clutter up the chat interface a little more than needed - but this works perfectly aside from that. good work.
quincyleung
force-pushed
the
live-chat/add-public-private-chat-toggle
branch
from
9be3aa4 to
8fef51c
Compare
…-public-private-chat-toggle
nathanL534
force-pushed
the
live-chat/add-public-private-chat-toggle
branch
from
8fef51c to
6ec794a
Compare
abargher
approved these changes
May 26, 2025
Contributor
abargher
left a comment
abargher
left a comment
There was a problem hiding this comment.
Looks like these commits got merged into dev in a prior PR-- all good, since there were conflicts being dealt with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #1102 and adds the ability for users to toggle between public and private chats on the main chat list page.
Closes #884.