feat: sync with upstream fork and support Better Auth 1.3.27 #12
Conversation
- Add OR connector support in findMany and count queries - Add sorting support in findMany with OR connectors - Add isRunMutationCtx option to adapter - Make createSchema async - Update types from CleanedWhere to Where - Fix error messages and return values - Add remeda dependency for sorting operations - Swap old and new doc params in onUpdate trigger (BREAKING) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: fcbc004 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| async ({ paginationOpts }) => { | ||
| return await ctx.runQuery(authFunctions.findMany, { | ||
| ...data, | ||
| paginationOpts, | ||
| where: parseWhere([w]), |
There was a problem hiding this comment.
When any OR connector appears, the adapter executes each clause separately and replaces the whole where array with the single OR condition (where: parseWhere([w])). This discards any non‑OR predicates that were present in the original query, so mixed queries such as (email = X OR username = Y) AND isActive = true will return documents that satisfy the OR condition even if isActive is false. The same pattern exists in both httpAdapter and dbAdapter for findMany and count, producing incorrect results and counts.
Useful? React with 👍 / 👎.
| { limit: data.limit } | ||
| ) | ||
| ); | ||
| const docs = unique(results.flatMap((r) => r.docs)); |
There was a problem hiding this comment.
After gathering the per‑clause pages, results are deduped with unique(results.flatMap(...)), which only compares object references. A document returned from two OR subqueries will be two different object instances and will therefore survive unique, so callers receive duplicates and count inflates the total. Deduplication needs to key off a stable identifier (e.g. _id) or use uniqueBy rather than the reference-based unique. The same issue affects both adapters’ count and findMany implementations.
Useful? React with 👍 / 👎.
Summary
Key Changes
findManyandcountusingasyncMapanduniquefindManywhen OR connectors are usedisRunMutationCtxoption added to adaptercreateSchemaasync for better module loadingCleanedWheretoWhereremedadependency for sorting operationsBreaking Change
onUpdatetrigger parameters have been swapped:onUpdate(ctx, oldDoc, newDoc)onUpdate(ctx, newDoc, oldDoc)This aligns with the upstream design where the new doc is used more frequently.
Test plan
httpAdapteranddbAdapterupdated with fork improvements🤖 Generated with Claude Code