fix: separate npm tag from release branch - #58
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the npm-release-ops reusable workflow contract so npm dist-tag selection (npm_tag) is independent from the Git release gate (release_branch), aligning npm publishing behavior with the documented intent (default publish to latest unless explicitly overridden).
Changes:
- Added a new
npm_tagworkflow input (defaultlatest) and plumbed it through job outputs/env. - Updated the publish step to use
npm_tagfornpm publish --tag, while keepingrelease_branchsolely for branch gating. - Updated docs and examples to include
npm_tagand clarify the migration for callers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
examples/npm-release-ops.yml |
Demonstrates providing npm_tag explicitly in the caller example. |
docs/workflows/npm-release-ops.md |
Documents the new npm_tag input, clarifies branch vs dist-tag behavior, and adds migration guidance. |
.github/workflows/npm-release-ops.yml |
Introduces npm_tag input and uses it for npm publishing while preserving release_branch gating logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
udx-github
approved these changes
Aug 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
examples/npm-release-ops.yml:20
provenanceandenable_gh_releaseare defined as boolean inputs in the reusable workflow, but this example passes them as quoted strings ("true"). Forworkflow_calltyped boolean inputs, this can fail validation in the caller workflow. Use YAML booleans (true/false) instead.
npm_tag: "latest"
provenance: "true"
dist_dir: "dist"
enable_gh_release: "true"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release_branchcurrently has two unrelated jobs: it identifies the Git branch allowed to release and becomes npm's--tagvalue. A caller that releases frommaintherefore publishes a package asmain, leaving the normallatestinstall on an older version.Change
npm_taginput, defaulting tolatestrelease_branchsolely as the Git release gateValidation
bash tests/docker-ops-build-args.sh