Skip to content

fix: separate npm tag from release branch - #58

Merged
fqjony merged 2 commits into
masterfrom
fix/npm-dist-tag
Aug 5, 2026
Merged

fix: separate npm tag from release branch#58
fqjony merged 2 commits into
masterfrom
fix/npm-dist-tag

Conversation

@fqjony

@fqjony fqjony commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Problem

release_branch currently has two unrelated jobs: it identifies the Git branch allowed to release and becomes npm's --tag value. A caller that releases from main therefore publishes a package as main, leaving the normal latest install on an older version.

Change

  • add an independent npm_tag input, defaulting to latest
  • retain release_branch solely as the Git release gate
  • document intentional non-default npm tags and the migration path

Validation

  • YAML parse
  • bash tests/docker-ops-build-args.sh

Copilot AI review requested due to automatic review settings August 5, 2026 17:36
@fqjony
fqjony requested review from a team and udx-github August 5, 2026 17:37
@fqjony fqjony self-assigned this Aug 5, 2026
@fqjony fqjony added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the npm-release-ops reusable workflow contract so npm dist-tag selection (npm_tag) is independent from the Git release gate (release_branch), aligning npm publishing behavior with the documented intent (default publish to latest unless explicitly overridden).

Changes:

  • Added a new npm_tag workflow input (default latest) and plumbed it through job outputs/env.
  • Updated the publish step to use npm_tag for npm publish --tag, while keeping release_branch solely for branch gating.
  • Updated docs and examples to include npm_tag and clarify the migration for callers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
examples/npm-release-ops.yml Demonstrates providing npm_tag explicitly in the caller example.
docs/workflows/npm-release-ops.md Documents the new npm_tag input, clarifies branch vs dist-tag behavior, and adds migration guidance.
.github/workflows/npm-release-ops.yml Introduces npm_tag input and uses it for npm publishing while preserving release_branch gating logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/npm-release-ops.yml
Copilot AI review requested due to automatic review settings August 5, 2026 18:11
@fqjony
fqjony merged commit a6d5c3b into master Aug 5, 2026
3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

examples/npm-release-ops.yml:20

  • provenance and enable_gh_release are defined as boolean inputs in the reusable workflow, but this example passes them as quoted strings ("true"). For workflow_call typed boolean inputs, this can fail validation in the caller workflow. Use YAML booleans (true/false) instead.
      npm_tag: "latest"
      provenance: "true"
      dist_dir: "dist"
      enable_gh_release: "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants