-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QC checks for ICE source files #1024
Add QC checks for ICE source files #1024
Conversation
Do you want this merged before #1013? |
They're independent. Either can go first. We use the warmstart files for one of the UWM RTs; the runs which created the failures are using the source files at their native resolution, so are not "fixed" with the QC in this utility. They'll need to implement something at point-of-use for those native resolution files w/ issues. |
*add initial unit test for ice QC *modify phantom ice QC, add tests for QC in unit test *revert changes in phantom-ice qc. restrict qc to match only what the ncap2 command produced * modify unit tests accordingly
2c6baca
to
d50ad8a
Compare
* fix failure in documentation build * add QC description to documentation
Baselines are located here: hera: /scratch1/NCEPDEV/stmp4/Denise.Worthen/OCNICE_PREP/BASELINE |
Thanks. I will host them in the official location. |
Looks good. Will merge, then update the baselines on all machines. |
DESCRIPTION OF CHANGES:
Implements some QC checks on the source CICE6 restart files to fix possible issues known to cause run-time failures in the coupled model. A unit test is added for the QC test functionality.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
ftst_qcice
test passed.ocnice_prep
consistency tests locally on all Tier 1 machines using new baseline data here. Done using fed6cd9.Describe any additional tests performed.
Baselines were run on Hera. The downscaled ocean warmstarts are B4B, as expected. The 1/2 deg and 1 deg ice files fail comparison. The only differences were seen in fields which are QC'd (category ice coverage, volume and snow volume and surface temperature).
The initial, unfixed IC restart file used during the investigation of the negative dvice issue was QC'd using the ocnice-prep utility. Using the
debug=.true.
setting for the ocnice-prep, the QC'd fields were dumped to a netCDF file. The four fields QC'd (aicen, vicen, vsnon, Tsfcn) were identical to those generated via ncap2 commands previously identified as fixing the negative dvice issue. For completeness, the script using ncap2 isISSUE: