Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doxygen in global_cycle #1026

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Feb 10, 2025

DESCRIPTION OF CHANGES:

  • Add definitions for two arguments in the read_data routine.
  • Add checks for missing optional argument LSOIL_INCR in read_data.
  • Update the pull request template to always require a branch be compiled with
    Doxygen before merging.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 88b38a8.
  • Compile branch on Hera using GNU. Done using 88b38a8.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Cactus using 88b38a8.
  • Run unit tests locally on any Tier 1 machine. Done on Cactus using 88b38a8. All tests passed.
  • Run global_cycle consistency tests locally on all Tier 1 machines. Done using 88b38a8. All tests passed as expected.

Describe any additional tests performed.

  • On Hera, the repository (at 88b38a8) was built with Doxygen with no errors. There were no warnings associated with the global_cycle code.

DEPENDENCIES:

None.

DOCUMENTATION:

Minor fixes to the Doxygen.

ISSUE:

Fixes #1025.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review February 10, 2025 19:32
Copy link
Collaborator

@yuanxue2870 yuanxue2870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the fix.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 0f8cb9f into ufs-community:develop Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

building documenation fails on develop branch
2 participants