Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 3572 remove tbr calculation #3605

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Conversation

chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Mar 25, 2025

This pull request focuses on removing the Tritium Breeding Ratio (TBR) calculation for the CCFE HCPB model and simplifying related code. The most important changes include the removal of the TBR calculation function, adjustments to related input variables, and updates to documentation and test files.

Removal of TBR calculation:

  • process/hcpb.py: Removed the tbr_shimwell function, which calculates the Tritium Breeding Ratio.

Code adjustments:

  • process/caller.py: Removed the code block that runs the TBR calculation for the CCFE HCPB model.
  • process/init.py: Removed input checks and assignments related to iblanket_thickness for the TBR calculation.

Documentation updates:

Test file updates:

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe linked an issue Mar 25, 2025 that may be closed by this pull request
@chris-ashe chris-ashe self-assigned this Mar 25, 2025
@chris-ashe chris-ashe force-pushed the 3572-remove-tbr-calculation branch from 4ba2a3b to 02e6ec7 Compare March 25, 2025 10:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.67%. Comparing base (2083732) to head (7f05cb2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
process/power.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
- Coverage   31.74%   31.67%   -0.08%     
==========================================
  Files          85       86       +1     
  Lines       20161    22242    +2081     
==========================================
+ Hits         6400     7045     +645     
- Misses      13761    15197    +1436     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe requested a review from timothy-nunn March 25, 2025 13:39
@chris-ashe chris-ashe marked this pull request as ready for review March 25, 2025 13:40
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to put iblanket_thickness into obsolete variables

@timothy-nunn timothy-nunn merged commit 542328b into main Mar 27, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the 3572-remove-tbr-calculation branch March 27, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TBR calculation
3 participants