-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 3572 remove tbr calculation #3605
Conversation
4ba2a3b
to
02e6ec7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 31.74% 31.67% -0.08%
==========================================
Files 85 86 +1
Lines 20161 22242 +2081
==========================================
+ Hits 6400 7045 +645
- Misses 13761 15197 +1436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to put iblanket_thickness
into obsolete variables
This pull request focuses on removing the Tritium Breeding Ratio (TBR) calculation for the CCFE HCPB model and simplifying related code. The most important changes include the removal of the TBR calculation function, adjustments to related input variables, and updates to documentation and test files.
Removal of TBR calculation:
process/hcpb.py
: Removed thetbr_shimwell
function, which calculates the Tritium Breeding Ratio.Code adjustments:
process/caller.py
: Removed the code block that runs the TBR calculation for the CCFE HCPB model.process/init.py
: Removed input checks and assignments related toiblanket_thickness
for the TBR calculation.Documentation updates:
documentation/proc-pages/eng-models/fw-blanket.md
: Updated the documentation to remove references to the TBR calculation for the CCFE HCPB model.Test file updates:
tests/integration/ref_dicts.json
: Removed references toiblanket_thickness
and the TBR calculation from the test configuration.Checklist
I confirm that I have completed the following checks: