Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support development of new checks #104

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Support development of new checks #104

merged 1 commit into from
Dec 6, 2024

Conversation

iay
Copy link
Member

@iay iay commented Dec 3, 2024

Initial cut at a setup intended to allow
development of new checks and their
associated tests.

@iay iay requested review from philsmart and alexstuart December 3, 2024 18:11
@iay
Copy link
Member Author

iay commented Dec 3, 2024

This is as described in issue #101. I think it's complete but the only real way to validate that assertion is to try and use it to develop a new check. Any volunteers?

@iay iay self-assigned this Dec 3, 2024
Copy link
Member

@philsmart philsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exactly matches my understanding of what is described #101. I do have a quick question, but I will add that to #101.

@iay
Copy link
Member Author

iay commented Dec 5, 2024

For @alexstuart : if reviewing, worth reading the more explicit description of an expected process at #101 (comment) first.

@alexstuart
Copy link
Member

For @alexstuart : if reviewing, worth reading the more explicit description of an expected process at #101 (comment) first.

The changes in the code look ok, and I agree that it is a complicated process for developing new checks.

@iay iay marked this pull request as ready for review December 6, 2024 16:26
@iay iay merged commit c0b2b6d into main Dec 6, 2024
2 checks passed
@iay iay deleted the 101-development branch December 6, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants