LTD-6074-f680-approval-letter-generation #2489
Conversation
depsiatwal
force-pushed
the
LTD-6074-f680-approval-letter-generation
branch
from
cfa884c to
70ced0c
Compare
depsiatwal
force-pushed
the
LTD-6074-f680-approval-letter-generation
branch
from
70ced0c to
4f2930f
Compare
api/letter_templates/templates/letter_templates/f680_approval.html
Outdated
Show resolved
Hide resolved
api/letter_templates/templates/letter_templates/f680_approval.html
Outdated
Show resolved
Hide resolved
api/letter_templates/templates/letter_templates/f680_approval_conditions.html
Outdated
Show resolved
Hide resolved
| </p> | ||
| <p>Yours sincerely,</p> | ||
|
|
||
| <p>signature here</P> |
There was a problem hiding this comment.
Do we need a special signed signature of some kind? I'm not sure how that works for SIELs
There was a problem hiding this comment.
Yeah I think we defo need a follow up
one to include the missing bits of pieces i.e Expiry date /signature and another for formatting
There was a problem hiding this comment.
Could you create a follow up ticket for this? And anything else you have in mind. Keen to make sure that we have the extra work noted down so we know what needs finishing pre-launch
There was a problem hiding this comment.
In case of SIELs I think we add a page at the end for digital signature, we need something similar in this case.
There was a problem hiding this comment.
I wanted to get a baseline template in that's kind of 90% there. I've written a jira for things like signature, remaining variables and formatting.
api/letter_templates/templates/letter_templates/includes/f680_approval_conditions.html
Outdated
Show resolved
Hide resolved
api/letter_templates/templates/letter_templates/f680_approval_conditions.html
Outdated
Show resolved
Hide resolved
api/letter_templates/templates/letter_templates/f680_approval.html
Outdated
Show resolved
Hide resolved
api/letter_templates/templates/letter_templates/includes/f680_approval_conditions.html
Outdated
Show resolved
Hide resolved
|
increased the scope slightly here to include the refusal to have a working baseline. |
depsiatwal
force-pushed
the
LTD-6074-f680-approval-letter-generation
branch
from
be85fba to
c5e5f09
Compare
| </div> | ||
| <div id="references" class="govuk-caption-m"> | ||
| Our Ref: {{ case_reference }}<br> | ||
| Your Ref: {{ details.user_reference }}<br><br> |
There was a problem hiding this comment.
This should be the application name, right? It seems to be missing in the generated document
| <p>This application is refused under</p> | ||
| {{ security_release_outcome.refusal_reasons }} |
There was a problem hiding this comment.
Looks like this departs from the template because we only have a refusal_reasons text block, and the template assumes full on refusal criteria like SIELs. Can we negotiate with UCD to adapt the template to just take a text block here?
depsiatwal
force-pushed
the
LTD-6074-f680-approval-letter-generation
branch
from
c5e5f09 to
df62d03
Compare
https://uktrade.atlassian.net/browse/LTD-6074
This Sets up the framework to generate the initial outcome letter.
There's a lot of work to do around formatting etc
But figure in this V0.1 we should as WIP await feedback and then look at formatting as a final task together with the refusal letter.